Show Line Numbers in Table Mode #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bers are hidden in table mode
…r other attributes added to the class="code" table cell. could you please review this regular expression to make sure it is correct. in my testing everything seemed to work correctly.
|
Sorry for the non passing tests. A couple had slipped through but all tests should be passing now, and the travis bot tests are passing as well. |
ghost
assigned
|
Actually, I want to remove these click handlers altogether. Feels like something that's better left to a bit of jQuery on the user's blog/website. |
|
I removed the feature altogether in d6546ed. Please use jQuery :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a dbl click handler to the code table cell to show the line numbers on double click if the line numbers were hidden.