Fix test suite for ruby 3.0 change for methods on subclass of Array #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ruby 3.0, especially with ruby/ruby#3690 , for subclass of Array, `flatten` method now returns the instance of Array, not of the subclass. To keep the object instance of the subclass, use `flatten!` instead.
|
Code Climate has analyzed commit c1c1503 and detected 0 issues on this pull request. View more on Code Climate. |
|
@rubychan Could you take a look at this PR? You can also add Ruby 3.0 case to this repo's Travis CI to see the result. Thanks. |
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ruby 3.0, especially with ruby/ruby#3690 ,
for subclass of Array,
flattenmethod now returns the instance of Array,not of the subclass.
To keep the object instance of the subclass, use
flatten!instead.Fixes #254