Fix debug_url for the latest version of Chrome #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jell
force-pushed
the
fix-debug-url-for-latest-chrome
branch
from
bba6462 to
f9099af
Compare
there was already a unit test exercising the logic, but no feature test actually running against a real browser instance. expecting this spec to fail on the latest version of chrome.
Jell
force-pushed
the
fix-debug-url-for-latest-chrome
branch
3 times, most recently
from
e154f86 to
9329405
Compare
it appears that devtoolsFrontendUrl returns a fully qualified URL in the latest version of Chrome, so it should be returned as-is without prepending anything to it.
Jell
force-pushed
the
fix-debug-url-for-latest-chrome
branch
from
9329405 to
5137e30
Compare
|
Nice, great job. was following through EvilMartian Vladimir setup up for better specs and was tearing my hair until I saw the Issues Page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first commit introduces a regression spec that fails in the CI on the latest version of Chrome, the second commit addresses the issue.
solves: #296
The fix should work with both old and new versions of chrome, thus making it a non-breaking change.