Skip to content

detect if element to be acted on is actually on top/viewable #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
route merged 1 commit into from
Nov 10, 2023
Merged

detect if element to be acted on is actually on top/viewable #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions lib/capybara/cuprite/javascripts/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ class Cuprite {
return true;
}


isDisabled(node) {
let xpath = "parent::optgroup[@disabled] | \
ancestor::select[@disabled] | \
Expand Down Expand Up @@ -344,10 +343,24 @@ class Cuprite {

_isInViewport(node) {
let rect = node.getBoundingClientRect();
return rect.top >= 0 &&
rect.left >= 0 &&
rect.bottom <= window.innerHeight &&
rect.right <= window.innerWidth;

let inViewport = rect.top >= 0 &&
rect.left >= 0 &&
rect.bottom <= window.innerHeight &&
rect.right <= window.innerWidth;

if (inViewport) {
// check if obscured by another element
let x = rect.width/2;
let y = rect.height/2 ;

let px = rect.left + x,
py = rect.top + y,
e = document.elementFromPoint(px, py);
return node == e;
}

return false;
}

select(node, value) {
Expand Down
6 changes: 6 additions & 0 deletions spec/features/driver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,12 @@ def create_screenshot(file, *args)
expect(@driver.body).to include("x: 100, y: 150")
end

it "supports clicking overlayed elements" do
@session.visit("/cuprite/click_overlay")
@session.click_link "hidden link"
expect(@driver.body).to include("hidden-link")
end

it "supports executing multiple lines of javascript" do
@driver.execute_script <<-JS
var a = 1
Expand Down
47 changes: 47 additions & 0 deletions spec/support/views/click_overlay.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<!DOCTYPE html>
<html>
<head>
<style type="text/css">
body {
width: 800px;
margin: 0;
}
#hidden-link {
position: relative;
top: 740px;
}
#wrapper {
height: 1200px;
}
#footer {
position: fixed;
left: 0;
bottom: 0;
width: 100%;
background-color: red;
color: white;
text-align: center;
height: 100px;
}
</style>
<script type="text/javascript">
window.onload = function() {
var log = document.querySelector("#log")
var boxes = document.querySelectorAll("#hidden-link")
for (var i = 0; i < boxes.length; i++) {
var el = boxes[i]
el.onclick = function() {
log.textContent = this.id
}
}
}
</script>
</head>
<body>
<div id="log"></div>
<div id="wrapper">
<a id="hidden-link" href="#">hidden link</a>
</div>
<div id="footer"></div>
</body>
</html>