keydown event sent without key property

[oliverguenther]

Cuprite sends custom keydown events to the node when using, e.g., fill_in here: https://github.com/rubycdp/cuprite/blob/main/lib/capybara/cuprite/javascripts/index.js#L192-L196

We're using Stimulus.js in our application, and using an action with a filter like keydown.esc->controller#cancel (which should trigger when pressing the escape key only), this interferes with Cuprite as it checks only for the key property, which with Cuprite refers to a number. https://github.com/hotwired/stimulus/blob/main/src/core/action.ts#L62

This results in the filter not matching and during a test written with Cuprite, the action to be triggered regardless of the key.

keyCode is deprecated and key is commonly supported in all browsers. Cuprite should set the key with the original pressed key (however it seems there is some logic behind setting the key value). https://caniuse.com/?search=event.key

I can submit a PR for that, but I'm still looking for how to actually set the key property correctly when creating a custom event.

[OutlawAndy]

Is there any plan to resolve this issue? My team is experimenting with switching to Cuprite. However, this issue is a huge blocker of that effort. It breaks any test where a Stimulus controller listening for keyboard events is involved.

[reedrolemodel]

Looks like this is fixed by #246

[route]

Please reopen if it's still an issue.

[oliverguenther]

Can confirm this fixes our issue. 👍 Would it be possible to create a new release from it?

[route]

I'm on it, most likely today.