Fix how SQLAuthLogic and SQLRestAuth fetch their user model class.#226
Merged
mitfik merged 4 commits intorubycas:masterfrom Sep 19, 2014
Merged
Fix how SQLAuthLogic and SQLRestAuth fetch their user model class.#226mitfik merged 4 commits intorubycas:masterfrom
mitfik merged 4 commits intorubycas:masterfrom
Conversation
Contributor
Author
|
Additionally, if this fix works, I think it should be applied to the encrypted SQL authenticator. I don't think the other patch #224 does the right thing, exactly. |
davexunit
force-pushed
the
issue-225
branch
from
57afae7 to
3522c7e
Compare
mitfik
pushed a commit
that referenced
this pull request
Sep 19, 2014
Fix how SQLAuthLogic and SQLRestAuth fetch their user model class.
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not tested this because I'm about to get on a bus, but I believe this patch will fix issue #225 or at least approximate the correct patch. The class method
user_modelhas been replaced withuser_models, which is a hash that keys user model classes by an authenticator'sauth_index. The base SQL authenticator has a method calleduser_modelthat will fetch the correct user model class.Could someone try it out?