Skip to content

minor fix to regression of post seeds after introducing rubocop #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leesheppard merged 2 commits into from
Feb 5, 2026
Merged

minor fix to regression of post seeds after introducing rubocop #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f9ba02
fix content enhanced seed which was returning '3' rather than the con…
lee-treehouse Feb 3, 2026
71d0c78
whitespace fix for herb
lee-treehouse Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/job_seekers/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<p>These members of Ruby Australia are currently seeking new opportunities.</p>
<% if user_signed_in? %>
<p>Visit your <%= link_to "profile settings", edit_my_details_path, class: "white-link"%> to add your LinkedIn profile and mark yourself as seeking work.</p>
<p>Visit your <%= link_to "profile settings", edit_my_details_path, class: "white-link" %> to add your LinkedIn profile and mark yourself as seeking work.</p>
<% end %>

<div class="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 gap-6 sm:gap-8">
Expand Down
8 changes: 4 additions & 4 deletions db/seeds/posts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,18 @@ def post_content_simple
end

def post_content_enhanced
content = "<strong>#{heading} #{Faker::Lorem.multibyte}</strong>"
content += "<br />"
content = "<strong>#{heading} #{Faker::Lorem.multibyte}</strong><br />"
Copy link
Member

@leesheppard leesheppard Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised Herb didn't complain about <br /> as the W3C validator now prompts warnings against the use of self closing brackets.

Copy link
Contributor Author

@lee-treehouse lee-treehouse Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t know about the w3c recc! Thanks for sharing!

content += "<em>#{Faker::Lorem.paragraph(sentence_count: 4, supplemental: true, random_sentences_to_add: 4)}</em>"
content += "<br /><br />"

content += "<strong>#{heading}</strong>"
content += "<br />"
content += "<strong>#{heading}</strong><br />"

3.times do
content += Faker::Lorem.paragraph(sentence_count: 8, supplemental: true, random_sentences_to_add: 4)
content += "<br /><br />"
end

content
end

def post_scheduling_attributes(draft: false, future_scheduled: false)
Expand Down