add link to ruby australia github org using github svg #436
add link to ruby australia github org using github svg #436leesheppard merged 2 commits intorubyaustralia:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a link to the Ruby Australia GitHub organization in the footer, using the official GitHub logo SVG. The change addresses issue #434 by providing a direct path for potential contributors to find the organization's repositories.
Changes:
- Added GitHub organization link with official GitHub logo to footer social media links
| </span> | ||
| <% end %> | ||
| <%= link_to "https://github.com/rubyaustralia", class: "text-metal footer-link", aria: { label: "Visit Ruby Australia's GitHub Organization" } do %> | ||
| <span class="fill-black hover:fill-ruby-red h-2 w-2 mr-8"> |
There was a problem hiding this comment.
The classes h-2 w-2 (which set height/width to 0.5rem/8px) don't match the visual size of the GitHub icon. These dimensions are inconsistent with the actual SVG viewBox (98x96) and would make the icon extremely small. Consider using classes that match the sizing of the adjacent X/Twitter icon for visual consistency.
There was a problem hiding this comment.
Good bot. I gave it a go, this was the best I could do that seemed consistent with the surrounds and didn't mess with aspect ratio of GitHub logo. When I changed the viewbox to match the others, the GitHub logo became very small.
|
@leesheppard heya Lee, I was wondering about the Heroku previews. Are they triggered automatically (I can't see a link on this open PR) or is it on request by a committer or administrator? Thanks! |
|
@lee-treehouse I have updated the layout of the footer to accommodate the the recent changes. As for the previews of the PRs, they should be generated once a PR that is seeking to merge with Main has been pushed up. I haven't seen the issue but will keep an eye out. Thank you :) |
Thanks Lee, I just didn't know where to look for the preview branch, I see it now: 
hmm and I see this now - maybe I've just been missing it, not knowing what to look for 🤷 
Layout changes to the footer look great 🙏 |
2 participants
addresses #434 (which was closed as being resolved by #435, but I think there was a separate requirement, for link to github repo)
Add logo link to Ruby Australia github organisation to encourage contributors.
For the logo, I sourced the svg from here. The aspect ratio is not quite the same as the others but I don't think GitHub would be keen to see us mess with it, with a little margin fiddling it looks neat enough to me (though I don't do much front end work, I won't be offended if someone wants to tidy it up a bit more 😆)
Discussion (out of scope of this PR). I'm not a designer and this is not too important, but is the right hand side of the footer and the left hand side of the footer starting to look a bit out of balance? I don't know how someone would fix it, maybe the red ruby should be larger, or standardize padding between links and logos on either side (... and I won't make any more suggestions because I really have no idea about design)
Desktop
Mobile