Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with bin/packs command having no output #35

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

alexevanczuk
Copy link
Contributor

This fixes an issue where we weren't forwarding terminal output to the main terminal, resulting in an unexpected lack of visible progress.

Before

~/workspace/zenpayroll - (main) $ bin/packs
Hello! What would you like to do? Run bin/packwerk update-deprecations
Running via Spring preloader in process 49546
~/workspace/zenpayroll - (main) $ 

After

~/workspace/zenpayroll - (main) $ bin/packs
Hello! What would you like to do? Run bin/packwerk update-deprecations
[TEST PROF INFO] Spring detected
Running via Spring preloader in process 49853
📦 Packwerk is inspecting X files
# lots of dots
📦 Finished in 8.58 seconds

No offenses detected
✅ `deprecated_references.yml` has been updated.

@alexevanczuk alexevanczuk merged commit 60bbe06 into main Oct 15, 2022
@alexevanczuk alexevanczuk deleted the ae-fix-no-output-from-bin-packs branch October 15, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant