Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add violations to ParsePackwerk call #131

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Add violations to ParsePackwerk call #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8915fe5
Add violations to ParsePackwerk call
professor Nov 21, 2023
e46c12e
Use parse_packwerk 0.20.1
professor Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ GEM
packs-specification (0.0.10)
sorbet-runtime
parallel (1.23.0)
parse_packwerk (0.20.0)
parse_packwerk (0.20.1)
sorbet-runtime
parser (3.2.2.3)
ast (~> 2.4.1)
Expand Down Expand Up @@ -211,4 +211,4 @@ DEPENDENCIES
tapioca

BUNDLED WITH
2.2.33
2.4.22
4 changes: 4 additions & 0 deletions lib/packs/private.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def self.move_to_parent!(
enforce_privacy: package.enforce_privacy,
enforce_dependencies: package.enforce_dependencies,
dependencies: package.dependencies,
violations: package.violations,
metadata: package.metadata,
config: package.config
)
Expand Down Expand Up @@ -214,6 +215,7 @@ def self.move_to_parent!(
enforce_privacy: other_package.enforce_privacy,
enforce_dependencies: other_package.enforce_dependencies,
dependencies: new_dependencies.uniq.sort,
violations: other_package.violations,
metadata: other_package.metadata,
config: new_config
)
Expand Down Expand Up @@ -304,6 +306,7 @@ def self.add_dependency!(pack_name:, dependency_name:)
dependencies: (package.dependencies + [dependency_name]).uniq.sort,
enforce_privacy: package.enforce_privacy,
enforce_dependencies: package.enforce_dependencies,
violations: package.violations,
metadata: package.metadata,
config: package.config
)
Expand Down Expand Up @@ -395,6 +398,7 @@ def self.create_pack_if_not_exists!(pack_name:, enforce_privacy:, enforce_depend
enforce_dependencies: should_enforce_dependencies || false,
enforce_privacy: enforce_privacy,
dependencies: [],
violations: [],
metadata: {},
name: pack_name,
config: config
Expand Down
134 changes: 46 additions & 88 deletions sorbet/rbi/gems/parse_packwerk@0.19.3.rbi → sorbet/rbi/gems/parse_packwerk@0.20.1.rbi
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions spec/packs_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def write_codeownership_config
enforce_privacy: true,
enforce_dependencies: false,
dependencies: [],
violations: [],
metadata: {},
config: { 'owner' => 'MyTeam' }
)
Expand Down
3 changes: 3 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
params(
pack_name: String,
dependencies: T::Array[String],
violations: T::Array[ParsePackwerk::Violation],
enforce_dependencies: T::Boolean,
enforce_privacy: T::Boolean,
visible_to: T::Array[String],
Expand All @@ -45,6 +46,7 @@
def write_package_yml(
pack_name,
dependencies: [],
violations: [],
enforce_dependencies: true,
enforce_privacy: true,
visible_to: [],
Expand All @@ -59,6 +61,7 @@ def write_package_yml(
package = ParsePackwerk::Package.new(
name: pack_name,
dependencies: dependencies,
violations: violations,
enforce_dependencies: enforce_dependencies,
enforce_privacy: enforce_privacy,
metadata: metadata,
Expand Down