Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for UsePackwerk.move_to_parent! #13

Merged
merged 5 commits into from
Aug 18, 2022

Conversation

alexevanczuk
Copy link
Contributor

@alexevanczuk alexevanczuk commented Aug 18, 2022

Summary

I ran an experiment in ZP to nest a pack.

Here's friction I discovered, with a

  • sorbet/config ignores a lot of spec files. We might want to auto-migrate those ignores for users.
  • A lot of package.yml files will reference the old packs in their dependencies. This led to two pieces of friction:
    • According to the validation, we must actually remove these, because nothing should depend on child packs. I think we should REMOVE this validation until there is an easier way to promote a child pack's public API to the parent pack. Otherwise, there is a huge barrier of entry for nested packs where folks will have to migrate all of their child packs public API to the parent pack. This validation lives in ZP right now so will be changed there.
    • ✅ This requires changing the name of the packs in each parent pack. I think I should update move_to_parent to do this for the user since we have commands to rewrite package.yml files with a new list of dependencies.
  • .rubocop.yml is hard-coded to packs/*/app/... type paths, so I needed to expand this. This configuration lives in ZP, so I changed it there.

Commits

  • add failing test
  • fix failing test
  • add other failing test
  • fix spec
  • bump version

@alexevanczuk alexevanczuk merged commit 42bab3b into main Aug 18, 2022
@alexevanczuk alexevanczuk deleted the ae-improve-nested-pack-ux branch August 18, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant