Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CSV format for get_info and allow including any violation types #110

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Support CSV format for get_info and allow including any violation types #110

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33be05e
Refactor to separate stats-collection from output (no visible change)
oboxodo Sep 10, 2023
7d6ca58
Use data instead of methods to distinguish violation type
oboxodo Sep 10, 2023
490dd31
Use hashes and arrays allow easy support for new types (no visible ch…
oboxodo Sep 10, 2023
b876ba6
Add support for reporting packs info in CSV format
oboxodo Sep 11, 2023
8c874fe
Include architecture violations on get_info
oboxodo Sep 11, 2023
7c24364
Allow specifying what types of violations to output on get_info
oboxodo Sep 11, 2023
9f419a5
Allow including a Date in the get_info report (useful for snapshots)
oboxodo Oct 6, 2023
3431f36
Prefer some more code readability over DRYness
oboxodo Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include architecture violations on get_info
  • Loading branch information
@oboxodo
oboxodo committed Oct 12, 2023
commit 8c874fe58f3e7d7e483d582183c732a6d4178dfa
2 changes: 1 addition & 1 deletion lib/packs/private.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ def self.packwerk_package_to_pack(package)
def self.get_info(packs: Packs.all, format: :detail)
require 'csv' if format == :csv

violation_types = %i[privacy dependency]
violation_types = %i[privacy dependency architecture]
violations = {
inbound: {},
outbound: {}
Expand Down