In Zlib::GzipReader#eof? check if we're actually at eof#72
Merged
nobu merged 1 commit intoruby:masterfrom Feb 22, 2024
Merged
Conversation
Only consider it eof if we read ahead and something fills the buf. If not, we may only have empty blocks and the footer. Fixes ruby#56
martinemde
force-pushed
the
martinemde/readpartial-fix
branch
from
524d9e0 to
437bea8
Compare
Contributor
Author
|
@nobu thank you 🙇♂️ |
k0kubun
pushed a commit
that referenced
this pull request
May 29, 2024
In Zlib::GzipReader#eof? check if we're actually at eof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking for
eof?, read ahead until we can confidently say that either there is more content or the stream is finished. If reading ahead fills thez->buf, we are not at eof.It's possible that only empty blocks or the footer remain to be read from the input stream. If
eof?is only based on current status of the stream, a following read may produce no output, causing an EOFError because there's nothing left to return. This only happens for very specific gzip file lengths that hit exactly at a modulo of the read size, leaving only empty blocks and the footer remaining to be read.Fixes #56