Conversation
|
Since we're the only one using this fork and the latest commit should always be installed, why do we need to tag it? |
|
I think that if we clearly record which commit hash of reline corresponds to which commit hash of yamatanooroti, we will avoid unnecessary confusion in case we need to revert reline. |
But have we ever done that before? I don't remember there's a time where we need to pin Having to tag |
I don't mean that.
Yeah, it's true, I also am not willing to spend time discussing this because it's not mandatory for this time as I said before. |
https://github.com/ruby/yamatanooroti/compare/d16c9cce6f99aec87bdc00335d5a8591bc52ba68..d6f94b44134c55a7750db37ccb8692ced9658136
Once this PR is merged, I want to tag
v0.0.10to this repository and write that tag in Reline's Gemfile: https://github.com/hasumikin/reline/blob/reline_face/Gemfile#L9