Fix parser and bump version to 0.3.3 #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Apr 12, 2023
___class___ node should not be removed when class Marshallable is not included in the requested class
kou
reviewed
Apr 13, 2023
|
Hello, Could you please validate this pr, and merge Regards, |
|
Can you add a test for this case? |
|
Hi, I added tests for the new code check |
|
this article has been published https://medium.com/@plenumlab/identifying-and-exploiting-unsafe-deserialization-in-ruby-97c7cbd6c05d |
|
Sorry. I've merged #35 instead of this but I credited you as one of reporters in our release note: https://github.com/ruby/xmlrpc/releases/tag/v0.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing a deserialization vulnerability when
ENABLE_MARSHELLINGis set to true