[en,ja]Add regression-of-hash-reject-in-ruby-2-1-1 #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, we should add a notice about it to 2.1.1 release announcement. Thought? |
|
Agreed: 1d35e76 |
There was a problem hiding this comment.
How about using "リグレッション" (or "不具合" simply) instead of "デグレード"?
In the English version, a word "regression" is used for it.
|
@sorah Good work, but I have no time to review your issue 🙏 |
There was a problem hiding this comment.
- A word "デグレード" is now replaced with "不具合" in the article about the regression.
- "...を発見しています" is a little unnatural. How about "が発見されました" or "を発見しました"?
|
The Japanese contents look good to me. 👍 |
There was a problem hiding this comment.
highlighted code with
{% highlight ruby %}
... code ...
{% endhighlight %}
|
OK, thanks |
sorah
added a commit
that referenced
this pull request
Mar 11, 2014
[en,ja]Add regression-of-hash-reject-in-ruby-2-1-1
|
Good work everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #665
This is requested by @nurse and @hsbt
CC: @zzak