Skip to content

Add CVE-2024-43398: DoS vulnerability in REXML #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

kou
Copy link
Member

@kou kou commented Aug 22, 2024

No description provided.

@kou kou requested a review from a team as a code owner August 22, 2024 01:47
@hsbt hsbt merged commit 92ea9b2 into ruby:master Aug 22, 2024
1 check passed
@kou kou deleted the rexml-cve-2024-43398 branch August 22, 2024 04:56

## Details

When parsing an XML that has many deep elements that have same local name attributes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing several previous articles, I think this would be appropriate. How do you think?

Suggested change
When parsing an XML that has many deep elements that have same local name attributes.
When parsing an XML that has many deep elements that have same local name attributes, REXML gem may take long time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you open a PR for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants