Skip to content

Correct release note on frozen to_s in 2.7.0-preview3 (de, es, ko, zh_cn, zh_tw) #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2020
Merged

Correct release note on frozen to_s in 2.7.0-preview3 (de, es, ko, zh_cn, zh_tw) #2383

merged 4 commits into from
Apr 1, 2020

Conversation

aleksandrilyin
Copy link
Contributor

Hello!
Done as in PR #2308 for de, es, ko, zh_cn and zh_tw translations.

@aleksandrilyin aleksandrilyin requested review from a team as code owners March 5, 2020 03:44
riseshia
riseshia reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@riseshia riseshia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ko diff. Thanks!

@yous yous mentioned this pull request Mar 5, 2020
Closed
@Quintus
Copy link
Contributor

Quintus commented Mar 5, 2020

Looks good for me (de).

vtamara
vtamara approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@vtamara vtamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es is fine

JuanitoFatas
JuanitoFatas approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@JuanitoFatas JuanitoFatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

aleksandrilyin and others added 2 commits March 9, 2020 03:20
@aleksandrilyin @JuanitoFatas
Improve translation in 2.7.0-preview3 (zh_cn)
d6f9d2f 
Co-Authored-By: Juanito Fatas <katehuang0320@gmail.com>
@aleksandrilyin @JuanitoFatas
Improve translation in 2.7.0-preview3 (zh_tw)
a3ce952 
Co-Authored-By: Juanito Fatas <katehuang0320@gmail.com>
@aleksandrilyin
Copy link
Contributor Author

aleksandrilyin commented Mar 9, 2020 •
edited
Loading

Thanks @JuanitoFatas for improvements, @marocchino for approval and others reviewers. Committed.

@aleksandrilyin
Copy link
Contributor Author

Hi!
/cc @dsh0416 please review these changes.

@aleksandrilyin
Copy link
Contributor Author

/cc @JuanitoFatas
@JuanitoFatas can you merge these changes please if all good?

@JuanitoFatas JuanitoFatas merged commit c021cd7 into ruby:master Apr 1, 2020
@JuanitoFatas
Copy link
Member

@aleksandrilyin awesome, thank you so much!!! ❤️

@aleksandrilyin aleksandrilyin deleted the 2_7_0-preview3-frozen-to_s branch April 2, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riseshia riseshia riseshia left review comments

@marocchino marocchino marocchino approved these changes

@vtamara vtamara vtamara approved these changes

@JuanitoFatas JuanitoFatas JuanitoFatas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aleksandrilyin @Quintus @JuanitoFatas @marocchino @vtamara @riseshia