remove unneeded bin/console and bin/setup files from gemspec#94
Merged
hsbt merged 1 commit intoruby:masterfrom May 25, 2022
olivia-fl:dont-package-bins
Merged
remove unneeded bin/console and bin/setup files from gemspec#94hsbt merged 1 commit intoruby:masterfrom olivia-fl:dont-package-bins
hsbt merged 1 commit intoruby:masterfrom
olivia-fl:dont-package-bins
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently (trying)[https://github.com/void-linux/void-packages/pull/31003] to package this for void, and have discovered that the
bin/consoleandbin/setupfiles are included in the gemspec, and would be installed in the system/usr/bindirectory when trying to install this package system-wide. My understanding is that these binaries are useful for development onwebrickonly, and should not be packaged, but I'm not familiar with ruby at all and could be wrong here.