Merged
Conversation
kirs
force-pushed
the
frozen-strings
branch
3 times, most recently
from
a5c4228 to
af95d7a
Compare
Contributor
|
@kirs Thanks for submitting a patch for this. I'm fine with these changes. Unless another committer objects in the next few days, I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports ruby/ruby#3560 to this repo.
frozen_string_literal: trueis a generally a good practice, and here it will make it easier to call some building blocks of WEBricks from places that require objects to be frozen (e.g. Ractor).cc @jeremyevans