Skip to content

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Aug 16, 2024

This uses now-compatible "os" choices for Ruby 2.4, 2.5.

This failed in the build of #31.

I enabled fail-fast: false to be able to iterate on the CI workflow.

Details Found this:
Bundler found conflicting requirements for the Ruby version:
  In Gemfile:
    tempfile was resolved to 0.2.1, which depends on
      Ruby (>= 2.5.0)

  Current Ruby version:
    Ruby (= 2.4.10)

EDIT: Noted that I had wrongly added 2.4 I am removing the 2.4 from the workflow.

Also: There are errors about a Tempfile lacking a filename in the failed tests. (These are for Ruby versions 3.1 and below.)

@olleolleolle olleolleolle changed the title CI: macos-13 for Ruby 2.4, 2.5 CI: macos-13 for Ruby 2.5 Aug 16, 2024
This uses now-compatible "os" choices for Ruby 2.5.

This failed in the build of #31.
@olleolleolle
Copy link
Contributor Author

Did the "anonymous: true" change fail for these (< Ruby 3.2) versions?
57e9af4

@olleolleolle
Copy link
Contributor Author

I suggest we merge this PR, to have better visibility on master about what CI results we have.

@hsbt
Copy link
Member

hsbt commented Aug 23, 2024

@olleolleolle Thanks for rising this. I added workaround for that at #35

@hsbt hsbt closed this Aug 23, 2024
@hsbt hsbt deleted the olleolleolle-patch-1 branch August 23, 2024 06:08
@olleolleolle
Copy link
Contributor Author

@hsbt Perfect fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants