Skip to content

Add workflow to ensure the gem installs fine on truffleruby #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add workflow to ensure the gem installs fine on truffleruby #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
os:
- ubuntu-22.04
- ubuntu-20.04
ruby: [ '2.7', '3.0', '3.1', '3.2', 'debug', 'head', 'jruby-head' ]
ruby: [ '2.7', '3.0', '3.1', '3.2', 'debug', 'head', 'jruby-head', 'truffleruby-head' ]
steps:
- uses: actions/checkout@v4
- name: Set up Ruby
Expand Down Expand Up @@ -42,5 +42,12 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
- name: Run test
# Tests don't pass yet on truffleruby
if: >-
matrix.ruby != 'truffleruby-head'
Comment on lines +45 to +47
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also use continue-on-error like for jruby just below, not sure what is best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I don't have an opinion for this. You can choose whichever you like.

run: bundle exec rake
continue-on-error: ${{ startsWith(matrix.ruby, 'jruby') }}
- name: Install gem
run: |
gem install pkg/*.gem
ruby -rstringio -e 'puts StringIO::VERSION'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for confirmation: This outputs 3.0.1 (not 3.1.1) on truffleruby-head. It's intentional, right?

https://github.com/ruby/stringio/actions/runs/7032124053/job/19135198739?pr=74#step:9:9

3.0.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because it uses truffleruby's stringio.rb.