Add C extension spec for rb_define_finalizer and rb_undefine_finalizer #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
force-pushed
the
finalizer-c-ext-spec
branch
from
040d6e6 to
201f7be
Compare
Member
|
This is failing on Windows for 3.4.1: https://github.com/ruby/spec/actions/runs/12771014042/job/35597187543 |
Member
Author
|
#1239 should fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic specs for rb_define_finalizer and rb_undefine_finalizer. The tests definitely do not provide full coverage, especially for exception cases, but it's a start.