Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for String#bytesplice #1035

Closed
wants to merge 1 commit into from
Closed

Add specs for String#bytesplice #1035

wants to merge 1 commit into from

Conversation

AI-Mozi
Copy link
Contributor

@AI-Mozi AI-Mozi commented May 18, 2023

#1016
[Feature #18598]

String#bytesplice has been added.

@AI-Mozi AI-Mozi force-pushed the add_specs_for_string_bytesplice branch from 4f9fc95 to d448851 Compare May 18, 2023 12:53
@andrykonchin
Copy link
Member

There is an in-progress PR in TruffleRuby that implements the #bytesplice method and adds specs. It was created last week so probably it's better to integrate your test cases with proposed in that PR (either during the review of that PR or after its merging).

https://github.com/oracle/truffleruby/pull/3044/files#diff-6b71643bbb22894a35bb9ecd60397eafb06ec89dba9da1c97e188d9e8e39d38f

@AI-Mozi AI-Mozi force-pushed the add_specs_for_string_bytesplice branch from d448851 to 83580fa Compare May 19, 2023 08:43
@AI-Mozi AI-Mozi force-pushed the add_specs_for_string_bytesplice branch from 83580fa to 7281385 Compare May 19, 2023 08:43
@AI-Mozi
Copy link
Contributor Author

AI-Mozi commented May 19, 2023

Thanks, I borrowed some test cases and adjust some of my :D

@AI-Mozi AI-Mozi marked this pull request as ready for review May 19, 2023 08:53
@AI-Mozi
Copy link
Contributor Author

AI-Mozi commented May 30, 2023

The specs were added here so I will close this PR.

@andrykonchin
Copy link
Member

Thank you for your efforts!

@AI-Mozi AI-Mozi closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @andrykonchin