bugfix: Fix bug that version cannot be parsed in .tool-versions #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Mar 11, 2025
| @@ -130,7 +130,7 @@ function parseRubyEngineAndVersion(rubyVersion) { | |||
| } else if (rubyVersion === '.tool-versions') { // Read from .tool-versions | |||
| const toolVersions = fs.readFileSync('.tool-versions', 'utf8').trim() | |||
| const rubyLine = toolVersions.split(/\r?\n/).filter(e => /^ruby\s/.test(e))[0] | |||
| rubyVersion = rubyLine.split(/\s/)[1] | |||
| rubyVersion = rubyLine.split(/\s+/)[1] | |||
There was a problem hiding this comment.
It makes me think we should really do https://github.com/ruby/setup-ruby/pull/717/files#r1982040471 but I merged this as-is to fix it ASAP.
We should also add a test for .tool-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #719
This PR fixes a regression introduced in PR #717, where the tool fails to correctly parse the Ruby version from .tool-versions when multiple spaces exist between the tool name and version.