Closed
Description
Currently the list is at https://github.com/ruby/setup-ruby/blob/master/ruby-builder-versions.json
But that means every time a Ruby is released we need to merge the automatic PR and make a release of setup-ruby too, even if nothing changes except that list (well, and the README, but we could just link to the list from the README).
That's a non-trivial overhead.
I'm thinking to move that list to https://github.com/ruby/ruby-builder which has the built Rubies already anyway.
It actually used to be like that a long while ago.
I don't recall all the reasons but the most important where:
- I used some NPM package for the HTTPS request, and that was getting multiple security issues per month (how does one even work in that ecosystem?) which was untenable. So having the file here avoided to depend on a problematic NPM package. But these days there is https://github.com/actions/toolkit/tree/main/packages/http-client or https://github.com/actions/toolkit/tree/main/packages/github which should address that
- We might hit some GitHub limits potentially if too many such requests are done in an amount of time.
- It seems a bit cleaner/safer to have the list in this action directly, rather than having to fetch it over the network. But the churn on releases is not great.
- Having the list here means new versions are automatically tested in the PR adding those versions.
One alternative might to merge the PR & create the release automatically, but that seems difficult to do safely.
Metadata
Metadata
Assignees
Labels
No labels