Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the vendored resolv library from version 0.6.2 to 0.7.0 to address compatibility issues with Ruby 3.2 and Rails 8.1. The PR description references a previous attempt (#9297) that removed the vendored resolv library, which caused conflicts with Ruby 3.2's bundled securerandom-0.2.2. This PR takes a different approach by continuing to vendor resolv for non-C-extension Ruby implementations while allowing Ruby implementations with C extensions to use the bundled version.
Changes:
- Updated resolv dependency from 0.6.2 to 0.7.0 across vendor gem specifications and lock files
- Updated the patch file reference from resolv-v0.6.3.patch to resolv-v0.7.0.patch
- Vendored the updated resolv 0.7.0 library with improvements including better Windows platform detection and enhanced documentation
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tool/bundler/vendor_gems.rb | Updates resolv version specification to 0.7.0 |
| tool/bundler/vendor_gems.rb.lock | Updates lock file with resolv 0.7.0 and its checksum |
| tool/automatiek/vendor.rb | Updates patch file reference to resolv-v0.7.0.patch |
| tool/automatiek/resolv-v0.7.0.patch | Defines the patch to apply to upstream resolv for vendoring (updates require statements) |
| lib/rubygems/vendor/resolv/lib/resolv.rb | Vendored resolv 0.7.0 with updated version constant, improved Windows detection, and enhanced documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsbt
added a commit
that referenced
this pull request
Feb 5, 2026
Update vendored resolv to 0.7.0 (cherry picked from commit 9c6ecda)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, #9297 is not working with Ruby 3.2. Ruby 3.2 have securerandom-0.2.2, It conflicts with the current stable version of Rails 8.1.
Although it is not recommended, use the resolv bundled with Ruby for C extensions, and use the vendored version for other Ruby implementations.