Skip to content

Ensure revision is always re-resolved in git_proxy.rb#9294

Merged
hsbt merged 1 commit intoruby:masterfrom
ianks:ianks/git-proxy-revision-fix
Feb 2, 2026
Merged

Ensure revision is always re-resolved in git_proxy.rb#9294
hsbt merged 1 commit intoruby:masterfrom
ianks:ianks/git-proxy-revision-fix

Conversation

@ianks
Copy link
Contributor

@ianks ianks commented Feb 1, 2026

When adding a local path: gem, revision was nil due to re-resolution. Error in bundle install for local path gems. The fix is to ensure revision is re-resolved by using accessor instead of ivar.

@ianks ianks changed the title Fix nil @revision in git_proxy.rb [bug] Ensure revision is always re-resolved in git_proxy.rb Feb 1, 2026
@ianks ianks changed the title [bug] Ensure revision is always re-resolved in git_proxy.rb Ensure revision is always re-resolved in git_proxy.rb Feb 1, 2026
@hsbt
Copy link
Member

hsbt commented Feb 2, 2026

👍

@hsbt hsbt merged commit d3512d0 into ruby:master Feb 2, 2026
92 checks passed
@ianks
Copy link
Contributor Author

ianks commented Feb 3, 2026

@hsbt can you release a patch version with this fix???

@hsbt
Copy link
Member

hsbt commented Feb 3, 2026

I will do that at next week.

hsbt added a commit that referenced this pull request Feb 5, 2026
Ensure revision is always re-resolved in `git_proxy.rb`

(cherry picked from commit d3512d0)
@hsbt
Copy link
Member

hsbt commented Feb 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants