Skip to content

Conversation

@deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Aug 11, 2025

What was the end-user or developer problem that led to this PR?

We had two duplicated specs checking essentially the same thing: that all subcommands and their flags are documented.

What is your fix for the problem, implemented in this PR?

This PR merges the specs to keep the best of each, and make sure all our commands pass them, resulting in more standard documentation for commands with subcommands (bundle config, bundle plugin, and bundle doctor).

Make sure the following tasks are checked

For synopsis, subcommand and flag documentation like other commands do.
Name default value placeholders in a more standard way. That's what our
specs check, but they don't yet work for subcommand flags.
Make synopsis, subcommands, and CLI flags use a format consistent with
the other docs, and also reword some sentences for clarify.
We had them duplicated, but with slightly different features:

* The ones in `other/cli_man_pages.rb` enforced a specific structure to
  document CLI options, so were less likely to have false positives.

* The ones in `quality_spec.rb` were able to check subcommands and their
  flags.

This commit merges both and preserves the best of both.
@deivid-rodriguez deivid-rodriguez changed the title Improve cli documentation Improve documentation of bundle doctor, bundle plugin, and bundle config Aug 11, 2025
@deivid-rodriguez deivid-rodriguez merged commit 9934845 into master Aug 13, 2025
76 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/improve-cli-documentation branch August 13, 2025 04:47
deivid-rodriguez added a commit that referenced this pull request Sep 4, 2025
…ocumentation

Improve documentation of `bundle doctor`, `bundle plugin`, and `bundle config`

(cherry picked from commit 9934845)
deivid-rodriguez added a commit that referenced this pull request Sep 9, 2025
…ocumentation

Improve documentation of `bundle doctor`, `bundle plugin`, and `bundle config`

(cherry picked from commit 9934845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants