Raise an error in frozen mode if some registry gems have empty checksums #8888
+113
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To save some unnecessary `bundle install` commands.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/detect-empty-checksums
branch
from
290437a to
05199ae
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 4, 2025
…checksums Raise an error in frozen mode if some registry gems have empty checksums (cherry picked from commit 3a42889)
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 9, 2025
…checksums Raise an error in frozen mode if some registry gems have empty checksums (cherry picked from commit 3a42889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Bundler is not able to detect missing checksums for registry gems. If
frozenmode is enabled, lockfile checksums are enabled, and a registry gem does not have a lockfile checksum, Bundler should refuse to install that gem.What is your fix for the problem, implemented in this PR?
It's a bit tricky because Bundler does not currently generate checksums for
gitorpathgems, so this strict mode should only apply to registry gems.This PR adds a
ChecksumStore#empty?method that we check when validating the lockfile, and makes sure it only applies to registry gems, not to git or path gems.Fixes #8885.
Make sure the following tasks are checked