Auto switch to locked bundler version even when using binstubs #7719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2024
deivid-rodriguez
force-pushed
the
deivid-rodriguez/auto-switch-from-binstubs
branch
2 times, most recently
from
7861ba8 to
da93615
Compare
4 tasks
deivid-rodriguez
force-pushed
the
deivid-rodriguez/auto-switch-from-binstubs
branch
from
da93615 to
076aba8
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 12, 2024
…rom-binstubs Auto switch to locked bundler version even when using binstubs (cherry picked from commit 975ee9d)
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 12, 2024
…rom-binstubs Auto switch to locked bundler version even when using binstubs (cherry picked from commit 975ee9d)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When people are running bundler through binstubs (that require
bundler/setupinstead of loading the CLI), and they are also installing gems to a local path, Bundler will fail to auto-switch to the locked version.This may cause old Bundler versions to run new lockfiles, causing issues like #7715.
What is your fix for the problem, implemented in this PR?
My fix is to make sure auto-switch also happens when requiring
bundler/setup, and not only when loading the CLI.Fixes #7715.
Make sure the following tasks are checked