fix pre-commit hook failing rubocop on non-ruby files #7046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you changed a man page, it was force-feeding that to rubocop, and it would fail every line as unparseable
martinemde
reviewed
Oct 9, 2023
| # Run rubocop hook only when analyzable files are present | ||
| if [[ $length -ne 0 ]]; then | ||
| ./bin/rubocop $files | ||
| ./bin/rubocop --only-recognized-file-types $files |
Contributor
There was a problem hiding this comment.
Should this go directly into bin/rubocop? I'm not sure I'd ever want to run rubocop on an unrecognized file.
Contributor
Author
|
At that point... why does Rubocop allow it at all?? To be clear, if you provide no files on the command line, or directories, then rubocop will only include files that match its include config. It's only if a file is explicitly named will rubocop ignore the config and always process it. Which is why the precommit hook is doing. |
Contributor
|
Good point, haha. Fixing it here makes sense then. |
Contributor
|
The test failure is the windows segfault. I'm ignoring that for now since it's happening on master too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If you changed a man page, it was force-feeding that to rubocop when committing, and it would fail every line as unparseable.
What is your fix for the problem, implemented in this PR?
Add the rubocop flag that tells it to apply file-type filters to the list of files passed on the command line.
Make sure the following tasks are checked