Skip to content

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 14, 2023

What was the end-user or developer problem that led to this PR?

My plugin would have a much cleaner implementation if it could hook both before and after the Gemfile is evaluated (the former to easily add additional DSL methods, the latter to do verification that the new methods were properly used).

What is your fix for the problem, implemented in this PR?

Add the hooks and call them from Definition.build (not Dsl#evaluate or Dsl#eval_gemfile, so as not to interfere with the plugin-parsing pass of the Gemfile).

Make sure the following tasks are checked

@ccutrer ccutrer mentioned this pull request Sep 14, 2023
@ccutrer ccutrer force-pushed the bundler-plugin-eval-hooks branch from 1883e8f to 5626626 Compare October 11, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant