Remove autorequire spec attribute #2832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've never seen this attribute used anywhere, but since it's a gemspec attribute, we should go through a deprecation cycle, right? |
Contributor
|
The comment actually says it doesn't really work, so maybe we can actually remove it? 🤔 What do you think @hsbt? |
Contributor
Author
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Jul 25, 2019
2832: Remove autorequire spec attribute r=bronzdoc a=bronzdoc # Description: Remove `autorequire`, maybe this should have been removed in RG3? 😬 `autorequire` was used by old RubyGems, it is neither supported nor functional. I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
Build succeeded |
ghost
merged commit
Contributor
|
@bronzdoc Unfortunately I think we need to revert this PR and go through a proper deprecation cycle, letting users know they need to remove this setting. I just tried last master branch of rubygems, and it crashed because I had a gem installed using this attribute... 😞 |
Contributor
Author
|
That sucks.... Ok, Will revert @deivid-rodriguez |
Member
|
A lot of gems still uses I'm okay to remove this attribute in RG 4.0, But It's good to warn to deprecated message in 3.1 or 3.2 👍 |
ghost
pushed a commit
that referenced
this pull request
Aug 5, 2019
2858: Revert cadb66 and deprecate specification autorequire r=hsbt a=bronzdoc # Description: See: #2832 ______________ I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove
autorequire, maybe this should have been removed in RG3? 😬autorequirewas used by old RubyGems, it is neither supported nor functional.I will abide by the code of conduct.