Skip to content

Commit

Permalink
Remove the Bash launcher for JRuby on Windows, always use jruby.exe
Browse files Browse the repository at this point in the history
* The Bash launcher causes warnings, see
  ruby/setup-ruby#13 (comment)
* Add tests when using an absolute path to jruby.
  • Loading branch information
eregon committed Jan 30, 2020
1 parent ba5351f commit 41e8f14
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
asset_content_type: application/gzip

buildJRubyWindows:
if: false
if: true
strategy:
fail-fast: false
matrix:
Expand All @@ -92,6 +92,8 @@ jobs:
mkdir ~/.rubies
tar xf jruby-dist-${{ matrix.jruby-version }}-bin.tar.gz -C ~/.rubies
cd ~/.rubies/${{ matrix.ruby }}/bin
# Remove the Bash launcher, always use jruby.exe
rm jruby
echo -en "@ECHO OFF\r\n@\"%~dp0jruby.exe\" %*\r\n" > ruby.bat
- name: Install Bundler if needed
shell: bash
Expand All @@ -108,6 +110,16 @@ jobs:
- name: Bundler version
run: ~/.rubies/${{ matrix.ruby }}/bin/ruby -S bundle --version

- name: Basic test (Bash)
run: ~/.rubies/${{ matrix.ruby }}/bin/jruby --version
shell: bash
- name: OpenSSL test (Bash)
run: ~/.rubies/${{ matrix.ruby }}/bin/jruby -ropen-uri -e 'puts open(%{https://rubygems.org/}) { |f| f.read(1024) }'
shell: bash
- name: Bundler version (Bash)
run: ~/.rubies/${{ matrix.ruby }}/bin/jruby -S bundle --version
shell: bash

- name: Create archive
run: tar czf ${{ matrix.ruby }}-${{ matrix.os }}.tar.gz -C ~/.rubies ${{ matrix.ruby }}
shell: bash
Expand Down Expand Up @@ -187,7 +199,7 @@ jobs:
asset_content_type: application/gzip

buildRubinius:
if: true
if: false
strategy:
fail-fast: false
matrix:
Expand Down

0 comments on commit 41e8f14

Please sign in to comment.