Skip to content

Fix reverse sort in xpath_parser #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naitoh merged 2 commits into from
May 3, 2025
+7 −1
Merged

Fix reverse sort in xpath_parser #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb0c9d2
Fix reverse sort in xpath_parser
tompng Apr 30, 2025
d5f5f83
Test xpathparser sort with preceding-sibling
tompng May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rexml/xpath_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ def sort(array_of_nodes, order)
if order == :forward
index
else
-index
index.map(&:-@)
end
end
ordered.collect do |_index, node|
Expand Down
6 changes: 6 additions & 0 deletions test/xpath/test_base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,12 @@ def test_preceding
assert_equal( 4, cs.length )
end

def test_preceding_sibling
d = REXML::Document.new("<a><b><c/><d/><x/></b><b><e/><x/></b></a>")
matches = REXML::XPath.match(d, "a/b/x/preceding-sibling::node()")
assert_equal(["e", "d", "c"], matches.map(&:name))
end

def test_following
d = Document.new "<a><b id='0'/><b/><b><c id='1'/><c id='2'/></b><b id='1'/></a>"
start = XPath.first( d, "/a/b[@id='0']" )
Expand Down
Loading