Add test for reset_variables in Reline::Config #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ima1zumi
commented
Sep 2, 2024
| @@ -62,10 +62,11 @@ def reset_variables | |||
| @keyseq_timeout = 500 | |||
| @test_mode = false | |||
| @autocompletion = false | |||
| @convert_meta = true if seven_bit_encoding?(Reline::IOGate.encoding) | |||
| @convert_meta = seven_bit_encoding?(Reline::IOGate.encoding) | |||
There was a problem hiding this comment.
I thought it would be better to use true/false instead of nil and true, so I made the change.
tompng
approved these changes
Sep 3, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 3, 2024
(ruby/reline#741) * Fix reset variables * Add assertion for reload * Add helper method to get instance variable value of Reline::Config ruby/reline@386f619ff5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the reset_variables method in the Reline::Config class. The new test ensures that the method correctly resets internal states. Additionally, the test has been refactored for improved readability.