Accept colon-style hash in test assertion #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hash#inspect is proposed to change to {key: value, non_symbol_key => value} in https://bugs.ruby-lang.org/issues/20433#note-10
st0012
approved these changes
Aug 5, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 5, 2024
(ruby/reline#732) Hash#inspect is proposed to change to {key: value, non_symbol_key => value} in https://bugs.ruby-lang.org/issues/20433#note-10 ruby/reline@1fd73b358a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash#inspect is proposed to change to
{key: value, non_symbol_key => value}in https://bugs.ruby-lang.org/issues/20433#note-10This pull request will make test pass in both current hash inspect style and the proposed hash inspect style.
Patch that change
Hash#inspectis here ruby/ruby#10924rake testpasses with colon style inspect patch, butrake test_renderingfails (2 failure).This does not affect ruby core ci, so I'd like to fix it after
Hash#inspectis changed in ruby head.