Separate prompt and input line in rendering #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
split_prompt_line_render
branch
2 times, most recently
from
ddca9a3
to
c2d49e1
Compare
Often, only one of prompt and input changes. Split prompt+input_line to a separate rendering item will improve differential rendering performance.
tompng
force-pushed
the
split_prompt_line_render
branch
from
c2d49e1
to
f0f734d
Compare
ima1zumi
reviewed
Apr 18, 2024
lib/reline/line_editor.rb
Outdated
| @@ -366,7 +366,7 @@ def screen_scroll_top | |||
| @scroll_partial_screen | |||
| end | |||
|
|
|||
| def wrapped_lines | |||
| def wrapped_prompt_lines | |||
There was a problem hiding this comment.
How about naming it wrapped_prompt_and_lines or wrapped_prompt_and_input_lines? This would make it clear that prompts and lines are returned separately.
There was a problem hiding this comment.
wrapped_prompt_and_input_lines looks good, thanks!
updated
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 23, 2024
(ruby/reline#652) * Separate prompt and input line in rendering Often, only one of prompt and input changes. Split prompt+input_line to a separate rendering item will improve differential rendering performance. * Rename method wrapped_prompt_lines to more descriptive name ruby/reline@16d82f1f23
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
(ruby/reline#652) * Separate prompt and input line in rendering Often, only one of prompt and input changes. Split prompt+input_line to a separate rendering item will improve differential rendering performance. * Rename method wrapped_prompt_lines to more descriptive name ruby/reline@16d82f1f23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split prompt and input_line passed to render_line_differential.
This will improve differential rendering performance in these cases
To separately render prompt and input_line, line items passed to render_line_differential is changed