Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.3 to CI #620

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add Ruby 3.3 to CI #620

merged 1 commit into from
Jan 4, 2024

Conversation

ima1zumi
Copy link
Member

No description provided.

@st0012
Copy link
Member

st0012 commented Dec 26, 2023

Maybe Reline can also adopt the ruby-versions workflow like IRB did? And with Ruby 3.3's change on readline, we'll need to tweak the matrix a bit too.

@ima1zumi ima1zumi force-pushed the add-3.3 branch 2 times, most recently from 0443b42 to 0e4886e Compare January 2, 2024 11:23
@ima1zumi
Copy link
Member Author

ima1zumi commented Jan 2, 2024

Thank you for your sharing. I've updated.

NOTE: readline mswin windows-latest fails in CI. Because the installation of io-console is failing. I have created a PR that solves this problem. ruby/io-console#65

@st0012
Copy link
Member

st0012 commented Jan 3, 2024

Thank you for the investigation and the fix! Since the PR has been merged, do you think we can point io-console to the GH source in Gemfile atm to workaround the issue?

@ima1zumi
Copy link
Member Author

ima1zumi commented Jan 4, 2024

@st0012
I added gem 'io-console', github: 'ruby/io-console' to Gemfile.
readline mswin windows-latest has passed, but other tests have failed. Unfortunately, we were unable to workaround it. https://github.com/ruby/reline/actions/runs/7411571609

I have requested a release of the io-console, but until then it will remain as is.

st0012
st0012 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think we can merge it first and wait for the release 👍

@st0012 st0012 merged commit 100cc16 into ruby:master Jan 4, 2024
76 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ima1zumi @st0012