Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VT100 sequence to erase previos line #670

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Use VT100 sequence to erase previos line #670

merged 1 commit into from
Dec 4, 2018

Conversation

nobu
Copy link
Member

@nobu nobu commented Nov 28, 2018

It has been supported also on Windows since 2.0.0, and recent Windows 10 supports it too.

aycabta
aycabta requested changes Nov 28, 2018
View reviewed changes
Copy link
Member

@aycabta aycabta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good patch, but please fix a typo, s/previos/previous/.

aycabta
aycabta approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@aycabta aycabta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you!

@aycabta aycabta merged commit 773bb29 into ruby:master Dec 4, 2018
@nobu nobu deleted the feature/VT100 branch December 4, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aycabta aycabta aycabta approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nobu @aycabta