Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Rubocop task after file generation. #650

Merged
merged 4 commits into from
Sep 7, 2018
Merged

Added Rubocop task after file generation. #650

merged 4 commits into from
Sep 7, 2018

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Sep 7, 2018

I always faced removing trailing-whitespace when I merged rdoc into ruby core repository.

ruby/ruby@6a052fc

I added rubocop for removing trailing-whitespace and added rubocop task on Rakefile.

aycabta
aycabta reviewed Sep 7, 2018
View reviewed changes
Copy link
Member

@aycabta aycabta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...I understand what you want, but the trailing-whitespace is rare-case and it's so small case. RuboCop is too "overspec" to RDoc in many ways. I don’t think I can agree with that.

@hsbt
Copy link
Member Author

hsbt commented Sep 7, 2018

I know your concern. But I use DisabledByDefault: true. So, We only use nit-pick style cop.

@hsbt hsbt merged commit 050030c into master Sep 7, 2018
@hsbt hsbt deleted the rubocop branch September 7, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aycabta aycabta aycabta left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @aycabta