Use original method notation #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At 297cd5a, method names are replaced with normalized text. But the feature has critical problems: 1) Some methods are replaced with parents class receiver For example, the document of BasicSocket describes #read_nonblock for inheritance, but it's replaced with IO#read_nonblock. This behavior confuses users. 2) Arguments are removed For example, the document of Time describes like below: Time.utc(99) means the year 99 AD, not 1999 AD. But it's replaced with: Time.utc means the year 99 AD, not 1999 AD. This behavior clearly is a bug. This patch removes the normalization logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At 297cd5a, method names are replaced with normalized text. But the feature has critical problems.
Some methods are replaced with parents class receiver
For example, the document of
BasicSocketdescribes#read_nonblockfor inheritance, but it's replaced withIO#read_nonblock. This behavior confuses users.Arguments are removed
For example, the document of Time describes like below:
But it's replaced with:
This behavior clearly is a bug.
This Pull Request removes the normalization logic.