Ignore frozen_string_literal magic comment (Fixes #389) #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The Travis failures appear to be related to hoe manifests, not this patch. |
Member
|
@jeremyevans Can you rebase master? I fixed to failures of travis on master branch. |
I believe that ruby supports magic comments in any order. Note that ruby appears to support a warn_indent magic comment which this doesn't handle.
jeremyevans
force-pushed
the
frozen-string-comment
branch
from
d63f621 to
653ac30
Compare
Contributor
Author
|
OK, I rebased against master and Travis is happy with this. |
Member
|
@jeremyevans Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that ruby supports magic comments in any order. Note
that ruby appears to support a warn_indent magic comment which
this doesn't handle.