any out, untyped in #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
pushed a commit
that referenced
this pull request
May 2, 2025
1. `lexerstate` should be `rbs_lexer_t` instead 2. Params representing `rbs_lexer_t` should be named `lexer` instead of `state` 3. `rbsparser_next_token` should be called `rbs_lexer_next_token` After this PR, all structs & functions we want to expose should have `rbs_` prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are renaming
anytountypedbecause of the following reasons:anyis confusing:anyis ? (TypeScript), top type (Scala, Swift, ...), or union type (Sorbet).anyis difficult: people often build their own intuition like any is a lie or any is a compromise.Renaming to
untypedwould help to avoid these problems.untypedis closer name to the true semantics of the type: no static type checking, runtime may type check.