Skip to content

Fail CLI queries for missing types #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mame merged 3 commits into from
Sep 18, 2026
Merged

Fail CLI queries for missing types #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cc4a8e
Fail CLI queries for missing types
OskarEichler Aug 29, 2026
9a9d38d
Add a test for CLI queries on missing classes
mame Sep 18, 2026
0296404
Merge branch 'master' into codex/missing-type-exit-status
mame Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/rbs/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ def run_ancestors(args, options)
end
else
stdout.puts "Cannot find class: #{type_name}"
return 1
end

0
Expand Down Expand Up @@ -380,6 +381,7 @@ def run_methods(args, options)
end
else
stdout.puts "Cannot find class: #{type_name}"
return 1
end

0
Expand Down
17 changes: 17 additions & 0 deletions test/rbs/cli_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,23 @@ module Bar = Kernel

end

def test_missing_class
with_cli do |cli|
refute_cli_success { cli.run(%w(ancestors ::NoSuchClass)) }
assert_equal "Cannot find class: ::NoSuchClass\n", stdout.string
end

with_cli do |cli|
refute_cli_success { cli.run(%w(methods ::NoSuchClass)) }
assert_equal "Cannot find class: ::NoSuchClass\n", stdout.string
end

with_cli do |cli|
refute_cli_success { cli.run(%w(method ::NoSuchClass foo)) }
assert_equal "Cannot find class: ::NoSuchClass\n", stdout.string
end
end

def test_validate
with_cli do |cli|
assert_cli_success cli.run(%w(--log-level=info validate))
Expand Down
Loading