Use character instead of byte count for parse#2859
Open
vinistock wants to merge 1 commit intoruby:masterfrom
Open
Use character instead of byte count for parse#2859vinistock wants to merge 1 commit intoruby:masterfrom
vinistock wants to merge 1 commit intoruby:masterfrom
Conversation
This commit updates the Rust crate's parse function to use character count instead of byte count when invoking the underlying C parser. This fixes an issue with multibyte characters in RBS. This commit also exposes the parse function's error message to provide more informative feedback when parsing fails. Finally, an integration sanity test is added to ensure that all RBS included in the repo can be correctly parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the Rust crate's parse function to use character count instead of byte count when invoking the underlying C parser. This fixes an issue with multibyte characters in RBS. Parsing the included RBS files was crashing on the assert for
rbs_skip.This commit also exposes the parse function's error message to provide more informative feedback when parsing fails.
Finally, an integration sanity test is added to ensure that all RBS included in the repo can be correctly parsed.