Skip to content

Delegate to Enumerable from Range#{min,max} #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 1 commit into from
Jun 9, 2025
Merged

Delegate to Enumerable from Range#{min,max} #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions core/range.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,10 +741,7 @@ class Range[out Elem] < Object
#
# Related: Range#min, Range#minmax.
#
def max: () -> Elem
| () { (Elem a, Elem b) -> Integer } -> Elem
| (Integer n) -> ::Array[Elem]
| (Integer n) { (Elem a, Elem b) -> Integer } -> ::Array[Elem]
def max: ...

# <!--
# rdoc-file=range.c
Expand Down Expand Up @@ -826,10 +823,7 @@ class Range[out Elem] < Object
#
# Related: Range#max, Range#minmax.
#
def min: () -> Elem
| () { (Elem a, Elem b) -> Integer } -> Elem
| (Integer n) -> ::Array[Elem]
| (Integer n) { (Elem a, Elem b) -> Integer } -> ::Array[Elem]
def min: ...

# <!--
# rdoc-file=range.c
Expand Down
32 changes: 18 additions & 14 deletions test/stdlib/Range_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,20 +80,6 @@ def test_last
('A'...'Z').last
end

def test_max
(1..10).max
(1..10).max(3)
(1..10).max { |i, j| i <=> j }
(1..10).max(3) { |i, j| i <=> j }
end

def test_min
(1..10).min
(1..10).min(3)
(1..10).min { |i, j| i <=> j }
(1..10).min(3) { |i, j| i <=> j }
end

def test_percent
(1..10).%(2)
if_ruby(..."3.4.0", skip: false) do
Expand Down Expand Up @@ -152,4 +138,22 @@ def test_overlap?
(2..5), :overlap?, (3..4)
)
end

def test_min
assert_send_type "() -> ::Integer", (1..4), :min
assert_send_type "() -> nil", (4..1), :min
assert_send_type "() { (::Integer, ::Integer) -> ::Integer } -> ::Integer", (1..4), :min do |a, b| a <=> b end
assert_send_type "() { (::Integer, ::Integer) -> ::Integer } -> nil", (4..1), :min do |a, b| a <=> b end
assert_send_type "(::Integer) -> ::Array[::Integer]", (1..4), :min, 2
assert_send_type "(::Integer) { (::Integer, ::Integer) -> ::Integer } -> ::Array[::Integer]", (1..4), :min, 0 do |a, b| a <=> b end
end

def test_max
assert_send_type "() -> ::Integer", (1..4), :max
assert_send_type "() -> nil", (4..1), :max
assert_send_type "() { (::Integer, ::Integer) -> ::Integer } -> ::Integer", (1..4), :max do |a, b| a <=> b end
assert_send_type "() { (::Integer, ::Integer) -> ::Integer } -> nil", (4..1), :max do |a, b| a <=> b end
assert_send_type "(::Integer) -> ::Array[::Integer]", (1..4), :max, 2
assert_send_type "(::Integer) { (::Integer, ::Integer) -> ::Integer } -> ::Array[::Integer]", (4..1), :max, 0 do |a, b| a <=> b end
end
end