Only load extconf_compile_commands_json when compiling through Rake #2498
Merged
soutaro merged 1 commit intoruby:masterfrom May 20, 2025
Merged
Only load extconf_compile_commands_json when compiling through Rake #2498soutaro merged 1 commit intoruby:masterfrom
soutaro merged 1 commit intoruby:masterfrom
Conversation
…asks Otherwise, it'd cause LoadError in official release because extconf_compile_commands_json is not a runtime dependency.
Member
|
@st0012 Does it fix the error? It looks like |
Member
Author
|
rubygems actually doesn't use So during normal gem installation, no rake tasks are executed, and the env var won't be set. |
soutaro
added a commit
that referenced
this pull request
Oct 10, 2025
Only load extconf_compile_commands_json when compiling through Rake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, it'd cause LoadError in official release because
extconf_compile_commands_jsonis not a runtime dependency.