Merged
Conversation
1433d21 to
92f5cbc
Compare
58585d3 to
44781eb
Compare
44781eb to
334cd97
Compare
amomchilov
reviewed
Apr 30, 2025
ac540b3 to
f06867e
Compare
Morriar
reviewed
Apr 30, 2025
Member
|
I'm good for clang-format. Can you add a commit for 4-space indentation? |
Member
Author
|
Updated the indent width to 4 👍 |
0543ef3 to
13f9dc3
Compare
2cd788d to
8a7cb1b
Compare
8a7cb1b to
013584a
Compare
st0012
commented
May 12, 2025
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libdb-dev curl autoconf automake m4 libtool python3 | ||
| - name: Install Re2c |
Member
Author
There was a problem hiding this comment.
@soutaro I decided to move all checking related tasks to the new c-check workflow so we can simplify the ruby builds too. WDYT?
| @@ -0,0 +1,74 @@ | |||
| --- | |||
| Language: Cpp | |||
Member
Author
There was a problem hiding this comment.
We have to explicitly list many rules here to reduce/avoid differences between clang-format versions, which is hard to enforce across dev machines and CI.
Member
Author
|
@soutaro I think it's ready for review |
Member
|
Updated the branch protection setting to require |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2025
Setup clang format for C code
soutaro
reviewed
May 15, 2025
| bundler-cache: none | ||
| - name: Set working directory as safe | ||
| run: git config --global --add safe.directory $(pwd) | ||
| - name: Set up permission |
Member
There was a problem hiding this comment.
This step causes an error...
(Other jobs are fixed in #2485.)
Member
|
Merged this PR to continue working on other PRs. |
Merged
soutaro
added a commit
that referenced
this pull request
Oct 6, 2025
Merged
soutaro
added a commit
that referenced
this pull request
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #2398, we found it necessary to have some sort of auto-formatting for C code as well to ensure consistent coding style. But instead of adding it as part of #2398, which already introduces many changes on the implementation itself, I think it'd be better to have the auto-formatting setup in a separate PR.
This PR:
clang-formatfor the project, including.clang-formatdefines the rules of formatting (likerubocop.yml)format:crake task will perform the formatting to all C code underext/,src/, andinclude/format:c_checkrake task will check if formatting is required without actually making the changesformat:c_check